feat: add AAC YAML support, replace Node.js CLI#1508
Merged
Conversation
hkad98
reviewed
Apr 1, 2026
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/aac.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
+ Coverage 77.32% 78.13% +0.80%
==========================================
Files 227 228 +1
Lines 14768 14926 +158
==========================================
+ Hits 11420 11662 +242
+ Misses 3348 3264 -84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hkad98
reviewed
Apr 1, 2026
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/aac.py
Outdated
Show resolved
Hide resolved
hkad98
reviewed
Apr 1, 2026
packages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/service.py
Outdated
Show resolved
Hide resolved
Add native support for Analytics-as-Code (AAC) YAMLs in the Python SDK, replacing the experimental Node.js-based gdc CLI with a pure Python implementation using the gooddata-code-convertors WASM package. - New aac.py module with individual conversion functions and workspace-level load/store for all supported AAC types (datasets, metrics, visualizations, dashboards, plugins, attribute hierarchies) - Rewritten gdc CLI: no npm/Node.js dependency, reads gooddata.yaml directly - Config alignment: SDK now understands VSCode plugin config fields (workspace_id, data_source, source_dir) - Extended CatalogWorkspaceService with load_and_put_aac_workspace and get_and_store_aac_workspace methods - 24 tests covering conversions, format detection, config parsing, and CLI JIRA: DX-326 risk: low
Add validate_python.sh wrapper script with --auto-fix and --scope support, following the gdc-nas pattern. Update AIDA validation registry and policy to use the new script with external_json processor. Pre-commit scope runs: format-fix, lint-fix, types (no tests). Pre-push scope runs: format-fix, lint-fix, types, test. Auto-fix mode uses make format-fix and make lint-fix targets to automatically resolve ruff formatting and import ordering issues. JIRA: DX-326 risk: nonprod
jaceksan
force-pushed
the
jacek/working
branch
2 times, most recently
from
23dca63 to
50f5c4f
Compare
hkad98
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add native support for Analytics-as-Code (AAC) YAMLs in the Python SDK, replacing the experimental Node.js-based gdc CLI with a pure Python implementation using the gooddata-code-convertors WASM package.
Test plan
JIRA: DX-326
risk: low